Run the full SQL review pass on a PR

At a glance

Learning objectives

• State the grain of every result set in one sentence
• Apply the review rules in order and stop at the first violation
• Emit findings with severity, location, rule, and a rewritten clause

What you need

• A pull request or a .sql file
• The target dialect (postgres/duckdb/snowflake)
• [object Object]

Steps

1. Read the diff and the file context. (from agent-sql-reviewer )
2. Establish the grain of every result set. (from agent-sql-reviewer )
3. State the grain of a result set in one sentence. (from skill-sql-review )
4. Prove a join cannot fan out before writing it. (from skill-sql-review )
5. Spot NULL-unsafe `NOT IN` and `=` predicates. (from skill-sql-review )
6. Emit findings with file:line and a rewritten clause. (from agent-sql-reviewer )

Check yourself

• On the 12-case fixture of known-bad SQL, findings cite severity, location, rule, and a fix — with 0 false positives.
• Every SELECT in the PR has a one-sentence grain statement before you judge the query.

Worked example

npx de-agent-platform add sql-review

1. Every join states its cardinality (1:1, N:1, N:N) and justifies it.
2. NOT IN (subquery) is banned where the subquery can return NULL - use NOT EXISTS.
3. Comparisons across types must be explicit casts, not implicit.
4. ORDER BY without LIMIT in a view is meaningless - drop it.
5. SELECT * in a persisted model freezes an unstable schema.

Findings list (severity, location, rule, fix)
Grain statement for each SELECT

Sourced from

• SQL Reviewer
• SQL Review

Security scan

Last sweep 2026-10-24: 0 finding(s), 0 marked as examples.

Common gotchas

• NOT IN with a nullable column never compares as you think; use NOT EXISTS.
• `ORDER BY` without `LIMIT` in a view is meaningless — drop it.
• `SELECT *` in a persisted model freezes an unstable schema.

Production considerations

• Keep the 12-case evaluation fixture in CI so regressions resurface.
• Emit findings with the exact predicate, the failure case, and a rewritten clause reviewers can verify.

Diagram

full review pass
   |
   |- read diff + context --> grain statement per result set
   |
   |- grain stated --> fan-out-proof joins --> NULL-unsafe predicates
   |
   |- emit findings --> file:line + rewritten clause --> verify on fixture

Registry stats